log-milestone-fields: stabilize across ms truncation#13019
Merged
bneradt merged 1 commit intoapache:masterfrom Mar 25, 2026
Merged
log-milestone-fields: stabilize across ms truncation#13019bneradt merged 1 commit intoapache:masterfrom
bneradt merged 1 commit intoapache:masterfrom
Conversation
Update the log-milestone-fields validator script to use a tolerance that matches per-field millisecond truncation. Also wait for the content of the expectred log lines, not just the existence of the log itself, before validating to ensure that the log entries are present when the validator runs.
bryancall
approved these changes
Mar 25, 2026
maskit
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the log-milestone-fields validator script to use a tolerance that matches per-field millisecond truncation. Also wait for the content of the expected log lines, not just the existence of the log itself, before validating to ensure that the log entries are present when the validator runs.